Repository navigation
Bring AGENTS.md up to date with the DEV-1013 wrapper and CI changes - #317
Merged
Merged
Conversation
DEV-1013 moved every module's wrapper to Gradle 8.14.3 and switched CI to the committed wrappers, but AGENTS.md still gave 8.10.2 and said CI builds only ShimmerDriverPC - in the Build section and again in the subproject table. gradle.yml now runs ./gradlew test in ShimmerDriver, then ./gradlew build -i in ShimmerDriverPC, whose settings.gradle includes :ShimmerDriver and :ShimmerBluetoothManager, so CI compiles and tests all three. Name the four Gradle subprojects CI still skips, and say that ShimmerTCPExample and simmerradiotest have no Gradle build at all instead of implying every subproject has a wrapper. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AGENTS.md predates DEV-1013 and still described the old build:
950406db(DEV-1013).ShimmerDriverPC, both in the Build section and in the subproject table. Since620e635c(DEV-1013),gradle.ymlruns./gradlew testinShimmerDriver, then./gradlew build -iinShimmerDriverPC.ShimmerDriverPC/settings.gradleincludes:ShimmerDriverand:ShimmerBluetoothManager, so CI compiles and tests all three.The warning to build locally now names the four Gradle subprojects CI still skips:
ShimmerLSL,JavaShimmerConnect,ShimmerTCPandShimmerPCBasicExamples.ShimmerTCPExampleandsimmerradiotestget their own sentence because they have no Gradle build at all. Both are Eclipse ADT Android projects, untouched since 2016, so "Each subproject carries its own wrapper" now says "Each Gradle subproject".CLAUDE.mdonly importsAGENTS.md, so it is unchanged.Verification
Checked against
masteratb2103062:*/gradle/wrapper/gradle-wrapper.propertiespoint atgradle-8.14.3-all.zip.JDK 11is still correct. CI sets up Temurin 11, and everysourceCompatibilityis1.11. The'1.8'lines inShimmerDriverPC/build.gradleare inside a/* */block.b2103062):Welcome to Gradle 8.14.3!.:ShimmerDriver:testand:ShimmerBluetoothManager:test, which writesShimmerBluetoothManager/build/test-results/test.This changes docs only, not the build.
🤖 Generated with Claude Code